Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124: use cosmology.api over the cosmology package #537

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

gh-124: use cosmology.api over the cosmology package #537

wants to merge 13 commits into from

Conversation

paddyroddy
Copy link
Member

Description

WIP

Closes: #124

Changelog entry

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy added enhancement New feature or request dependencies Pull requests that update a dependency file science Science improvement or question labels Feb 26, 2025
@paddyroddy paddyroddy self-assigned this Feb 26, 2025
@paddyroddy paddyroddy mentioned this pull request Feb 27, 2025
Merged
5 tasks
@paddyroddy paddyroddy reopened this Feb 28, 2025
paddyroddy
paddyroddy commented Feb 28, 2025
View reviewed changes
pyproject.toml
"glass",
"glass.ext.camb",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised that the .ext.camb is captured by glass from isort POV

paddyroddy
paddyroddy commented Feb 28, 2025
View reviewed changes
pyproject.toml
Comment on lines 158 to 159
"camb",
"camb.sources",
"cosmology",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised that the .sources is captured by camb from isort POV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paddyroddy paddyroddy

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request science Science improvement or question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use cosmology API instead of deprecated cosmology package
1 participant
@paddyroddy