Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-571: add a 20 min timeout to example runs #582

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

Saransh-cpp
Copy link
Member

Description

The examples roughly take 12-13 minutes to run. A 20 minutes timeout on this particular step should be good!

Closes: #571

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@Saransh-cpp Saransh-cpp self-assigned this Mar 10, 2025
@Saransh-cpp Saransh-cpp added the infrastructure Project infrastructure: dev tools, packaging, etc. label Mar 10, 2025
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to change this once #535 is merged, but let's see

@paddyroddy paddyroddy merged commit becc09b into main Mar 12, 2025
15 checks passed
@paddyroddy paddyroddy deleted the saransh/set-timeout branch March 12, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set a timeout for the examples test
3 participants