feat(deprecations): deprecations page that lists x-glean-deprecations #232
+2,931
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
travis-hoover-glean
force-pushed
the
travishoover/deprecations
branch
2 times, most recently
from
63b43a4 to
941dbad
Compare
travis-hoover-glean
force-pushed
the
travishoover/deprecations
branch
from
941dbad to
f35e198
Compare
Contributor
Author
|
@cursoragent review |
|
Taking a look! |
travis-hoover-glean
force-pushed
the
travishoover/deprecations
branch
from
f35e198 to
4f48ee3
Compare
travis-hoover-glean
force-pushed
the
travishoover/deprecations
branch
from
fa6ce5a to
d525eb2
Compare
travis-hoover-glean
force-pushed
the
travishoover/deprecations
branch
from
d525eb2 to
f5f1fc9
Compare
david-hamilton-glean
approved these changes
Dec 11, 2025
Member
david-hamilton-glean
left a comment
david-hamilton-glean
left a comment
There was a problem hiding this comment.
Looks great. Couple minor points of feedback.
Member
There was a problem hiding this comment.
2/5 (minor preference, non-blocking)
is it feasible to add tests for this?
scripts/generate-deprecations.mjs
Outdated
| * | ||
| * @type {EndpointGroup[]} | ||
| */ | ||
| const EXTRA_DEPRECATIONS = []; |
Member
There was a problem hiding this comment.
3/5 (strong opinion: non-blocking)
Can we add something in README that mentions how to add custom deprecations? Doesn't need to be anything involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new deprecations overview and list page to show all upcoming deprecations derived from x-glean-deprecated. Currently behind the x-glean-deprecated feature-flag.
Example: