Restrict units to what is defined in NGFF schema #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
This lists valid space and time units per https://ngff.openmicroscopy.org/latest/#axes-md, and rejects anything not included in those lists. As indicated in #144,
pixelis one of several units that are supported by OME-XML schema but not NGFF.I debated whether to implement this by defining NGFF schema units, or defining just units that don't overlap between the two schemas (as in #144 (comment)). I think the former approach is going to be easier to keep up to date, but happy to hear other opinions.
With the test data mentioned in #288,
bioformats2raw --debug mri.ome.tiff mri.zarrshould log thatpixelunits are being omitted, andmri.zarr/0/.zattrsshould show nounitattribute for anything underaxes.