-
Notifications
You must be signed in to change notification settings - Fork 9
README updates (requirements, installation & usage) #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add libblosc as a requirement of the extension - Separate the installation from the usage as top-level section - Describe the deployment via modifying an existing server or rebuilding - Expand the requirements of the Zarr data that can be read - Describe the two types of Zarr paths that can be used (filesystem and S3) - Describe the profile and anonymous query parameters
melissalinkert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions aside, looks good to me.
Co-authored-by: Melissa Linkert <[email protected]>
README.md
Outdated
| as `s3://<endpoint>/<bucket>/<prefix>` where `<endpoint>` is the S3 | ||
| endpoint - see https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region | ||
| for the list of the regional AWS S3 endpoints, <bucket> is the bucket name | ||
| and `<prefix>` is the prefix to the Zarr multiscales group e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that this can now be done on the command-line:
$ omero obj ext-info-set Image:1 3 com.glencoesoftware.ngff:multiscales s3://<endpoint>/<bucket>/<prefix>
since ome/omero-py#453
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to other cross-references in the README, is there a dedicated page either in the OMERO reference documentation or an OMERO guide that would describe the command and its prerequisites and could be linked here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think so. It's quite recent and has a limited audience so far.
But this is a good place to start!
kkoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple notes
| - or the URI specifying the location of the multiscales group if the Zarr is | ||
| stored on AWS S3 or S3 compatible storage. The location must be specified | ||
| as `s3://<endpoint>/<bucket>/<prefix>` where `<endpoint>` is the S3 | ||
| endpoint - see https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two notes here:
- If the expectation is that users will be manually setting the
lsid, I think we should mention that at least for S3 URIs we need them to be URL encoded. - We might want to make it clear that the URI will probably end with the series as we do in the local filesystem example. People might expect the URI for their Zarr image would end in
.zarr.
will-moore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx 👍
Fixes #29 and documents the new features introduced in #27 and #28, currently released as
0.6.0-rc1/cc @dominikl @jburel