Skip to content

Conversation

@sbesson
Copy link
Member

@sbesson sbesson commented Sep 16, 2025

Fixes #29 and documents the new features introduced in #27 and #28, currently released as 0.6.0-rc1 /cc @dominikl @jburel

  • Add libblosc as a requirement of the extension
  • Separate the installation from the usage as top-level section
  • Describe the deployment via modifying an existing server or rebuilding
  • Expand the requirements of the Zarr data that can be read
  • Describe the two types of Zarr paths that can be used (filesystem and S3)
  • Describe the profile and anonymous query parameters

- Add libblosc as a requirement of the extension
- Separate the installation from the usage as top-level section
- Describe the deployment via modifying an existing server or rebuilding
- Expand the requirements of the Zarr data that can be read
- Describe the two types of Zarr paths that can be used (filesystem and S3)
- Describe the profile and anonymous query parameters
Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions aside, looks good to me.

README.md Outdated
as `s3://<endpoint>/<bucket>/<prefix>` where `<endpoint>` is the S3
endpoint - see https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region
for the list of the regional AWS S3 endpoints, <bucket> is the bucket name
and `<prefix>` is the prefix to the Zarr multiscales group e.g.
Copy link

@will-moore will-moore Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that this can now be done on the command-line:

$ omero obj ext-info-set Image:1 3 com.glencoesoftware.ngff:multiscales s3://<endpoint>/<bucket>/<prefix>

since ome/omero-py#453

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to other cross-references in the README, is there a dedicated page either in the OMERO reference documentation or an OMERO guide that would describe the command and its prerequisites and could be linked here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so. It's quite recent and has a limited audience so far.
But this is a good place to start!

Copy link
Member

@kkoz kkoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a couple notes

Comment on lines +57 to +60
- or the URI specifying the location of the multiscales group if the Zarr is
stored on AWS S3 or S3 compatible storage. The location must be specified
as `s3://<endpoint>/<bucket>/<prefix>` where `<endpoint>` is the S3
endpoint - see https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two notes here:

  1. If the expectation is that users will be manually setting the lsid, I think we should mention that at least for S3 URIs we need them to be URL encoded.
  2. We might want to make it clear that the URI will probably end with the series as we do in the local filesystem example. People might expect the URI for their Zarr image would end in .zarr.

@sbesson sbesson requested a review from kkoz September 18, 2025 07:52
@sbesson sbesson requested a review from will-moore September 18, 2025 08:18
Copy link

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx 👍

@sbesson sbesson merged commit e899c81 into glencoesoftware:master Sep 18, 2025
6 checks passed
@sbesson sbesson deleted the readme_0.6.0_updates branch September 18, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation documentation

5 participants