Open
Conversation
Member
|
LGTM. Please how can we test these changes? |
Author
|
globalize-compiler didn't have tests for the Babel behaviour so I wasn't sure how to add tests for the TypeScript behaviour. To test yourself you could use If you run that on the stable version, it won't find any formatters and will error out. If you try it on the PR version it will find the transpiled formatter and output like normal. If you wanted you could also validate the TypeScript output I provided. You should just need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript's transforms are a bit different from Babel's resulting in globalize-compiler not always working on pre-compiled TypeScript code.
The following basic example will be transpiled by TypeScript as such:
Sometimes you cannot configure aliases to override globalize to the globalize-runtime so it's reasonable to require globalize-runtime directly. In TypeScript this would be transpiled as such.