-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitleaks securityTest #389
Conversation
I've also set the severity of issues based on the rule:
|
because gitleaks outputs stderr into stdout, we cannot decide based on stderr, but we can decide based on return code:
|
Hey, @abzcoding! I am currently working on this cool PR and found an issue. Would you mind confirming it and also helping me debug it? These were the steps I followed:
Although |
ok, I'll try to investigate the issue. |
@rafaveira3 can you verify that the issue has been resolved? |
in case you wanted to test it against a vulnerable repository:
|
Hey, @abzcoding! Well, this is awkward... 😅 Would you mind adding that if condition again for the
Let's merge it after this last commit! 🚀 |
no problem, i've implemented it. p.s: i've mistakenly closed and reopened the issue 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abzcoding, thanks a LOT for this contribution! We are certain that gitleaks
will help a lot of developers improve the quality of their code in a secure manner. You rock! 🚀🔥
Closes #366
I'm not sure that is it better to add Gitleaks as a generic type or a language type called "git"
please feel free to guide me on that one