Adds Infer as a new Security Test#542
Open
thepabloaguilar wants to merge 4 commits intoglobocom:masterfrom
Open
Adds Infer as a new Security Test#542thepabloaguilar wants to merge 4 commits intoglobocom:masterfrom
Infer as a new Security Test#542thepabloaguilar wants to merge 4 commits intoglobocom:masterfrom
Conversation
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
spimpaov
reviewed
Oct 20, 2021
Contributor
spimpaov
left a comment
spimpaov
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @thepabloaguilar! I made a few comments on your code 😊
thepabloaguilar
force-pushed
the
issue-511
branch
from
fc3a787 to
b7e585f
Compare
gabriel-cantergiani
suggested changes
Oct 21, 2021
| mkdir -p ~/.ssh && | ||
| echo '%GIT_PRIVATE_SSH_KEY%' > ~/.ssh/huskyci_id_rsa && | ||
| chmod 600 ~/.ssh/huskyci_id_rsa && | ||
| echo "IdentityFile ~/.ssh/huskyci_id_rsa" >> /etc/ssh/ssh_config && |
Contributor
There was a problem hiding this comment.
Hey @thepabloaguilar ! I tried to run an analysis using infer and received a few errors. The /etc/ssh directory does not exist in this image, so I was getting an error when trying to write to a file inside it. Could you check if there is any command missing here?
| # mkdir the man/man1 directory due to Debian bug #863199 | ||
| RUN apt-get update \ | ||
| && mkdir -p /usr/share/man/man1 \ | ||
| && apt-get install --yes --no-install-recommends \ |
Contributor
There was a problem hiding this comment.
I think the git installation is missing here. While debugging errors inside the container I couldn't clone the repository because git wasn't available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Inferas a new Security TestProposed Changes
There are no breaking changes here!
Testing
Inferwill work for Java projects, in order to test you need to setup huskyCI locally and runmake run-client-linuxusing some Java repo!Closes #511