Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom image to the pdf #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ndkshr
Copy link

@ndkshr ndkshr commented Jun 29, 2021

Why this PR?

  • Adding a default flag is not very liberating.

What it does?

  • Adds sys arg functionality for accepting a runtime path for the custom image
  • Changes the variable name for flag -> custom_image

Example

  • python pdfedit.py custom_image.jpg

Note: Maybe a larger image might cause some issues, have to test that case too!

### Why this PR?
- Adding a default flag is not very liberating.

### What it does?
- Adds sys arg functionality for accepting a runtime path for the custom image
- Changes the variable name for `flag` -> `custom_image`

### Example
- `python pdfedit.py custom_image.jpg`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant