Skip to content

Conversation

@orthagh
Copy link
Contributor

@orthagh orthagh commented Oct 21, 2025

@orthagh orthagh requested a review from cedric-anne October 21, 2025 13:58
@cgrard
Copy link

cgrard commented Oct 23, 2025

Salut Alexandre

In my opinion it would be even better to use environnement variables with default values to handle this (and extend it to OPcache settings for instance), here is an example of what I have in mind : feat/phpini_some_values...cgrard:docker-images:feat/phpini_some_values

This way we can let the default do its job or define an override in the docker-compose (or k8s manifest in my case)

Comment on lines +9 to +11
; allow posting larger files (e.g., for attachments)
post_max_size = 20M
upload_max_filesize = 20M
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GLPI upload handler split files into chunks to be able to upload large files without having to change this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you certain every upload pass in this handler ? avatar, service-catalog tiles ?

upload_max_filesize = 20M

; Increase values for large operations
memory_limit = 256M
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the GLPI installation, we says that the memory limit requirement is 64M. Should we change this requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants