Skip to content

Use string variables to fix /bin/sh: 1: [: Illegal number: 8.5 issue #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedric-anne merged 1 commit into from
Jan 6, 2026
Merged

Use string variables to fix /bin/sh: 1: [: Illegal number: 8.5 issue #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion githubactions-php-apache/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ RUN \
\
# Install XMLRPC PHP extension.
&& apt install --assume-yes --no-install-recommends --quiet libxml2-dev \
&& if [ $PHP_MAJOR_VERSION -lt "8" ]; then \
&& if [ "$PHP_MAJOR_VERSION" -lt "8" ]; then \
# For PHP < 8.x, install bundled extension
docker-php-ext-install xmlrpc \
; else \
Expand Down
2 changes: 1 addition & 1 deletion githubactions-php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ RUN \
\
# Install XMLRPC PHP extension.
&& apt install --assume-yes --no-install-recommends --quiet libxml2-dev \
&& if [ $PHP_MAJOR_VERSION -lt "8" ]; then \
&& if [ "$PHP_MAJOR_VERSION" -lt "8" ]; then \
# For PHP < 8.x, install bundled extension
docker-php-ext-install xmlrpc \
; else \
Expand Down
6 changes: 3 additions & 3 deletions glpi-development-env/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN apt update \
&& docker-php-ext-install bcmath \
\
# Install opcache PHP extension (it is already enabled in PHP 8.5+ images).
&& if [ $PHP_MINOR_VERSION -ne "8.5" ]; then \
&& if [ "$PHP_MINOR_VERSION" -ne "8.5" ]; then \
docker-php-ext-install opcache \
; fi \
\
Expand All @@ -70,7 +70,7 @@ RUN apt update \
&& docker-php-ext-install zip \
\
# Install xdebug PHP extension.
&& if [ $PHP_MAJOR_VERSION -lt "8" ]; then \
&& if [ "$PHP_MAJOR_VERSION" -lt "8" ]; then \
pecl install xdebug-3.1.6 \
; else \
# xdebug 3.5.0 is not available on PECL, its distribution is now made through PIE
Expand All @@ -83,7 +83,7 @@ RUN apt update \
\
# Install XMLRPC PHP extension.
&& apt install --assume-yes --no-install-recommends --quiet libxml2-dev \
&& if [ $PHP_MAJOR_VERSION -lt "8" ]; then \
&& if [ "$PHP_MAJOR_VERSION" -lt "8" ]; then \
# For PHP < 8.x, install bundled extension
docker-php-ext-install xmlrpc \
; else \
Expand Down
2 changes: 1 addition & 1 deletion glpi/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ RUN apt-get update \
&& docker-php-ext-install bcmath \
\
# Install opcache PHP extension (it is already enabled in PHP 8.5+ images).
&& if [ $PHP_MINOR_VERSION -ne "8.5" ]; then \
&& if [ "$PHP_MINOR_VERSION" -ne "8.5" ]; then \
docker-php-ext-install opcache \
; fi \
\
Expand Down