Add script to wait for DB to be ready before doing GLPI actions #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
requested changes
Jan 13, 2026
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
GLPI_DB_HOST, GLPI_DB_USER, GLPI_DB_PASSWORD and GLPI_DB_PORT are not strictly mandatory. Indeed, our image can be used without them, for instance with GLPI_SKIP_AUTOINSTALL/GLPI_SKIP_AUTOUPDATE set to true.
By the way, we could force GLPI_SKIP_AUTOINSTALL/GLPI_SKIP_AUTOUPDATE to true when the GLPI_DB_* are not defined or empty.
cedric-anne
approved these changes
Jan 13, 2026
cedric-anne
reviewed
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves race conditions in Docker environments where the database container may still be initializing.
Often occurring on the first docker startup (mysql will in that case create the DB, user etc).
Docker healthcheck-based
depends_onnot needed anymoreThe
depends_on: condition: service_healthyapproach only works withdocker compose. This application-level wait works in any orchestration environment (Kubernetes, Swarm, Podman, manual docker run).Once merged, the healthcheck configuration in docker-compose.yml can now be safely removed #244, #250.
This should also closes #190