fix(menu): pass state object to trigger function #3274
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Menu component's trigger function signature declares a second argument
state: { open: boolean }(seetypes.ts), but the implementation never actually passed it. This caused the trigger to always receiveundefinedfor the state argument.The fix: Add
{ open: state.isOpen }as the second argument to the trigger call inupdatedTrigger().Problem
When using the Menu component with a trigger that needs to display different UI based on whether the menu is open or closed, the
state.openproperty was alwaysundefined:Root Cause
In
packages/gluestack-core/src/menu/creator/Menu.tsx, theupdatedTriggerfunction only passed the props object:Fix
Pass the state object as the second argument to match the declared type signature:
Test Plan
state.openistruewhen menu is open andfalsewhen closed🤖 Generated with Claude Code