Skip to content

Conversation

gmac
Copy link
Owner

@gmac gmac commented Mar 17, 2025

This eliminates some redundancies between the stitching Request object and GraphQL::Query, and generally makes the stitching request behave more like a normal query. This includes:

  • Adds variable validations; these were missing (breaking behavior, though fundamentally a bug).
  • Non-null variables with only default values are caught by validations (matches base library).
  • Removes Request.prepare! without replacement. It's now incorporated directly into request plumbing.
  • Evaluates runtime possible types through the request query rather than the static schema (prepares for visibility).
  • Operation error messages match the base GraphQL Ruby library.

@gmac gmac merged commit 304d3ee into main Mar 17, 2025
6 checks passed
@gmac gmac deleted the use_graphql_query branch March 17, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant