Repository navigation
ci(checks): add CI OK aggregate job as the required status check - #26
Merged
Merged
Conversation
esterlus
force-pushed
the
este/ci-ok-required-check
branch
from
September 25, 2026 09:16
c0ec095 to
789aa63
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Remove the always-failing fail-probe before merging.
Review effort: Lite
Findings: None
What changed in this PR
Adds a stable aggregate CI OK status check for the pull-request workflow.
Changes:
- Adds
CI OKdepending on existing CI jobs. - Adds a temporary failing probe to validate failure propagation.
| File | Description |
|---|---|
.github/workflows/pr.yaml |
Defines the aggregate check and temporary failure probe. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a single
CI OKjob that depends on every other job inpr.yaml, so the branch ruleset can gate on one stable context instead of a hand-maintained list of check names. Same pattern already landed ingnosis_vpn-app(#506).if: always()is essential: without it a failed dependency marks this job skipped, and GitHub counts a skipped required check as passing.fail-probejob that always exits 1. It is here to proveCI OKactually turns red when a dependency fails — the one property thegnosis_vpn-approllout could not verify, and the one whose failure mode is silent. It is removed in a follow-up commit before merge.