perf(otelstorage): optimize allocations in `Hash` #298

tdakkota · 2024-01-17T10:32:23Z

                 │   old.txt   │               new.txt               │
                 │   sec/op    │   sec/op     vs base                │
_metricsBatch-32   1.257m ± 0%   1.095m ± 1%  -12.83% (p=0.000 n=15)

                 │   old.txt    │               new.txt                │
                 │     B/op     │     B/op      vs base                │
_metricsBatch-32   511.2Ki ± 0%   290.8Ki ± 0%  -43.11% (p=0.000 n=15)

                 │   old.txt   │               new.txt               │
                 │  allocs/op  │  allocs/op   vs base                │
_metricsBatch-32   7.894k ± 0%   6.280k ± 0%  -20.45% (p=0.000 n=15)

Use stack-allocated slice, if possible. ``` Hash-32 767.7n ± 1% 684.8n ± 2% -10.80% (p=0.000 n=15) Hash-32 384.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=15) Hash-32 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=15) ```

Use `strings.Compare` instead of `cmp.Compare`. ``` Hash-32 685.3n ± 3% 571.6n ± 2% -16.59% (p=0.000 n=15) ```

tdakkota added 3 commits January 17, 2024 12:57

perf(otelstorage): add Hash benchmark

5206cfa

perf(otelstorage): optimize allocations in Hash

60b8d63

Use stack-allocated slice, if possible. ``` Hash-32 767.7n ± 1% 684.8n ± 2% -10.80% (p=0.000 n=15) Hash-32 384.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=15) Hash-32 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=15) ```

perf(otelstorage): optimize sorting in Hash

b596b06

Use `strings.Compare` instead of `cmp.Compare`. ``` Hash-32 685.3n ± 3% 571.6n ± 2% -16.59% (p=0.000 n=15) ```

tdakkota requested a review from ernado as a code owner January 17, 2024 10:32

ernado merged commit 6e2ede0 into main Jan 17, 2024
15 checks passed

ernado deleted the perf/improve-hash branch January 17, 2024 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(otelstorage): optimize allocations in `Hash` #298

perf(otelstorage): optimize allocations in `Hash` #298

tdakkota commented Jan 17, 2024 •

edited

Loading

perf(otelstorage): optimize allocations in Hash #298

perf(otelstorage): optimize allocations in Hash #298

Conversation

tdakkota commented Jan 17, 2024 • edited Loading

perf(otelstorage): optimize allocations in `Hash` #298

perf(otelstorage): optimize allocations in `Hash` #298

tdakkota commented Jan 17, 2024 •

edited

Loading