Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(chstorage): do not make an unnecessary copy of encoded attributes #305

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Jan 21, 2024

For #293.

                 │   old.txt    │               new.txt               │
                 │    sec/op    │   sec/op     vs base                │
_metricsBatch-32   1059.2µ ± 0%   824.0µ ± 1%  -22.21% (p=0.000 n=15)

                 │    old.txt     │               new.txt                │
                 │      B/op      │     B/op      vs base                │
_metricsBatch-32   290.716Ki ± 0%   4.317Ki ± 0%  -98.51% (p=0.000 n=15)

                 │   old.txt    │              new.txt               │
                 │  allocs/op   │ allocs/op   vs base                │
_metricsBatch-32   6280.00 ± 0%   16.00 ± 0%  -99.75% (p=0.000 n=15)

```
                │   old.txt    │              new.txt               │
                 │    sec/op    │   sec/op     vs base               │
_metricsBatch-32   1088.5µ ± 1%   992.1µ ± 1%  -8.86% (p=0.000 n=15)

                 │   old.txt    │               new.txt                │
                 │     B/op     │     B/op      vs base                │
_metricsBatch-32   290.8Ki ± 0%   156.4Ki ± 0%  -46.23% (p=0.000 n=15)

                 │   old.txt   │               new.txt               │
                 │  allocs/op  │  allocs/op   vs base                │
_metricsBatch-32   6.280k ± 0%   3.247k ± 0%  -48.30% (p=0.000 n=15)
```
```
                 │   old.txt   │               new.txt               │
                 │   sec/op    │   sec/op     vs base                │
_metricsBatch-32   991.2µ ± 0%   816.9µ ± 1%  -17.59% (p=0.000 n=15)

                 │    old.txt     │               new.txt                │
                 │      B/op      │     B/op      vs base                │
_metricsBatch-32   156.363Ki ± 0%   4.306Ki ± 0%  -97.25% (p=0.000 n=15)

                 │   old.txt    │              new.txt               │
                 │  allocs/op   │ allocs/op   vs base                │
_metricsBatch-32   3247.00 ± 0%   16.00 ± 0%  -99.51% (p=0.000 n=15)
```
@tdakkota tdakkota requested a review from ernado as a code owner January 21, 2024 11:38
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (401f437) 72.96% compared to head (d06609c) 72.99%.
Report is 22 commits behind head on main.

Files Patch % Lines
internal/chstorage/inserter_metrics.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   72.96%   72.99%   +0.03%     
==========================================
  Files         178      178              
  Lines       13884    13881       -3     
==========================================
+ Hits        10130    10132       +2     
+ Misses       3254     3249       -5     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit b411a2a into main Jan 21, 2024
16 checks passed
@ernado ernado deleted the perf/optimize-attributes branch January 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants