markup: improve code block readability and isolate copy button #34009
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, code blocks did not support horizontal scrolling, leading to poor readability on mobile or narrow displays due to forced line wrapping. This patch updates the HTML structure and CSS so that: - Code blocks now scroll horizontally instead of wrapping lines - The copy button is placed in a separate wrapper to avoid layout interference These changes improve overall accessibility and usability for markdown-rendered content in the Gitea interface.
This reverts commit 95f7abb.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
modifies/go
|
Awesome |
|
There are people who prefer to always wrap code (me), and ones who don't. I think instead of this, we need a per-user preference that controls whether we wrap code everywhere or not. Singling out these inline blocks to not wrap seems a bad solution to me, we should either wrap everything or nothing. PS: Reason I prefer to always wrap is because I think vertical scrollbars are bad UX. |
|
To be clear, are you saying we should apply code wrapping consistently—either everywhere or nowhere—based on a user preference? |
pull-request-size
bot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the rendering of code blocks in markdown content (e.g., README.md) for better readability and UI stability across screen sizes.
Problem
pre-wrap), which caused line breaks on narrow or mobile displays.Changes
overflow-x: auto) for code blockswhite-space: preResult
Affected Files
modules/highlight/highlight.go— changed rendered HTML structuremodules/markup/markdown/markdown.go— passed format optionsweb_src/css/markup/codecopy.css— copy button isolationweb_src/css/markup/content.css— horizontal scroll and white-space handlingweb_src/js/markup/codecopy.ts— adjusted to handle isolated copy areaNotes
This is a UI/UX refinement that improves the usability of code blocks, especially for developers reading source code on mobile devices or narrow displays.