Polyfill WeakRef #34025
Merged
Polyfill WeakRef #34025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
Have tested it:
|
silverwind
approved these changes
Mar 26, 2025
GiteaBot
added
lgtm/need 1
|
I compared with https://github.com/jaenster/weakref-pollyfill/blob/master/src/index.js and implementation seems pretty much the same. |
|
Yes, our code is less that that one because we do not need to handle other environments. And actually most browsers have builtin WeakRef support, and most polyfill packages are inactive for many years, I just don't want to introduce another stale dependency ...... |
|
Yeah, no need for a dependency for such simple polyfills. |
lunny
approved these changes
Mar 26, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 26, 2025
wxiaoguang
added a commit
that referenced
this pull request
Mar 26, 2025
Backport #34025 by wxiaoguang Fix #33407 Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 27, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Download actions job logs from API (go-gitea#33858) Fail mirroring more gracefully (go-gitea#34002) Fix dropdown module accessing (go-gitea#34026) Polyfill WeakRef (go-gitea#34025) Fix dropdown delegating and some UI problems (go-gitea#34014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33407