Skip to content

support the open-icon of folder #34168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 29, 2025
Merged

support the open-icon of folder #34168

merged 17 commits into from
Apr 29, 2025

Conversation

kerwin612
Copy link
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang April 10, 2025 03:04
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 10, 2025
@wxiaoguang

This comment was marked as outdated.

Sign in to view
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 10, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 10, 2025
@kerwin612
Copy link
Member Author

I think we need to decouple the "basic theme" and "material theme"

According to your suggestion, I've newly submitted two commits. I'm not sure if they achieve the decoupling you mentioned.

@kerwin612
Extract the parameter of RenderEntryIconWithOpenStatus from `git.Tr…
ec3dcaf 
…eeEntry` to `FileEntry` to decouple it from `git.TreeEntry`.

This change will allow integrating the file icons of the file tree on the diff page into the unified rendering logic without relying on `git.TreeEntry`.
@wxiaoguang

This comment was marked as outdated.

Sign in to view
@wxiaoguang wxiaoguang marked this pull request as draft April 13, 2025 12:19
@kerwin612 kerwin612 marked this pull request as ready for review April 16, 2025 01:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2025
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@wxiaoguang wxiaoguang removed their request for review April 22, 2025 07:11
@wxiaoguang wxiaoguang marked this pull request as draft April 22, 2025 15:58
@kerwin612 kerwin612 marked this pull request as ready for review April 28, 2025 11:00
@kerwin612 kerwin612 requested a review from a team April 28, 2025 11:02
@kerwin612 kerwin612 requested review from yp05327 and hiifong April 29, 2025 00:06
@lunny lunny added this to the 1.25.0 milestone Apr 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2025
@kerwin612 kerwin612 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2025
@lunny lunny merged commit 2b76993 into go-gitea:main Apr 29, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2025
@kerwin612 kerwin612 deleted the support-folder-open-state branch April 29, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

@yp05327 yp05327 Awaiting requested review from yp05327

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kerwin612 @wxiaoguang @lunny @hiifong @techknowlogick @GiteaBot