Skip to content

Merge index.js #34963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

Merge index.js #34963

merged 3 commits into from
Jul 6, 2025
+212 −210

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 5, 2025 •
edited
Loading

Fix #34960

Before:

asset js/index.js 2.71 MiB
asset js/webcomponents.js 322 KiB

After:

asset js/index-domready.e55cb44a.js 2.41 MiB
asset js/index.js 361 KiB [emitted]

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 5, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Jul 5, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jul 5, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-js-load branch 9 times, most recently from f8d9ebc to d033ea5 Compare July 5, 2025 14:18
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 5, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 6, 2025 04:32
@wxiaoguang wxiaoguang merged commit 429efc8 into go-gitea:main Jul 6, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 6, 2025
@wxiaoguang wxiaoguang deleted the fix-js-load branch July 6, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Proposal: merge webcomponents.js into index.js and load js in the page head
4 participants
@wxiaoguang @lunny @delvh @GiteaBot