fix: remove duplicate IDs #35210
Open
fix: remove duplicate IDs #35210
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/templates
silverwind
reviewed
Aug 4, 2025
silverwind
reviewed
Aug 4, 2025
Co-authored-by: silverwind <[email protected]> Signed-off-by: Kerwin Bryant <[email protected]>
Co-authored-by: silverwind <[email protected]> Signed-off-by: Kerwin Bryant <[email protected]>
appleboy
approved these changes
Aug 4, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Aug 5, 2025
GiteaBot
added
lgtm/done
wxiaoguang
previously requested changes
Aug 5, 2025
GiteaBot
added
lgtm/blocked
wxiaoguang
reviewed
Aug 5, 2025
kerwin612
force-pushed
the
feature/multi-line-selection-url
branch
from
291c27c to
886f546
Compare
|
Have you fixed the problems? 
ps: I don't have time recently, feel free to ask other maintainers to review and dismiss my "change request" if the bugs have been fixed. |
wxiaoguang
reviewed
Aug 9, 2025
wxiaoguang
reviewed
Aug 11, 2025
kerwin612
changed the title
|
No need to ask for my review. Actually I don't understand the details of "feat: support multi-line selection with URL parameters" and "fix: remove duplicate IDs", no idea about the changed code (most changes have been reverted and only one line changes now), so no idea what it is going to fix.
If you know what it is for and have tested it, and it works as expectation, feel free to remove my "change request". |
lunny
dismissed
wxiaoguang’s stale review
The PR's purpose changed. Now it will remove the duplicated div id to prevent possible problem.
GiteaBot
added
lgtm/done
lunny
added
type/bug
backport/v1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.