Skip to content

Use gitrepo.Repository instead of wikipath #35398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Use gitrepo.Repository instead of wikipath #35398

wants to merge 32 commits into from
+250 −166

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 2, 2025 •
edited
Loading

Now the wikipath will not be referenced directly.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 2, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 2, 2025
@lunny lunny marked this pull request as ready for review September 3, 2025 02:27
@lunny lunny changed the title Use gitrepo.Repository instead of most of wikipath Use gitrepo.Repository instead of wikipath Sep 17, 2025
@lunny lunny added this to the 1.26.0 milestone Sep 25, 2025
Zettat123
Zettat123 reviewed Oct 7, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2025
@yp05327
Copy link
Contributor

yp05327 commented Oct 10, 2025

It seems that the tests are removed, but there's no new one added?

@lunny
Copy link
Member Author

lunny commented Oct 10, 2025

It seems that the tests are removed, but there's no new one added?

The method repo_model.WikiPath has been removed, so that the related test is removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @yp05327 @Zettat123 @GiteaBot