Skip to content

Update JS deps #35978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2025
Merged

Update JS deps #35978

merged 4 commits into from
Nov 20, 2025

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 18, 2025

Update JS deps, regenerate SVGs, fixed lint issues and did cursory testing of UI.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2025
@silverwind silverwind mentioned this pull request Nov 18, 2025
Draft
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2025
@silverwind
Copy link
Member Author

silverwind commented Nov 19, 2025

Updated again, fix new markdownlint issue and also added a make lint-md-fix (it did not autofix unfortunately).

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2025
@lunny
Copy link
Member

lunny commented Nov 20, 2025

Why were these new octicon-xxx icons added? It seems they aren’t used anywhere in the codebase. Could you clarify their purpose?

@delvh
Copy link
Member

delvh commented Nov 20, 2025

@lunny they came from the updated octicon dependency.

@silverwind
Copy link
Member Author

silverwind commented Nov 20, 2025 •
edited
Loading

We generate all svgs into the repo, only the used ones will actually end up in the build.

@silverwind silverwind enabled auto-merge (squash) November 20, 2025 08:07
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2025
@silverwind silverwind merged commit 1baca49 into go-gitea:main Nov 20, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 20, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 20, 2025
@silverwind silverwind deleted the deps-102 branch November 20, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/docs modifies/frontend modifies/internal

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind @lunny @delvh @a1012112796 @GiteaBot