Skip to content

Conversation

@ericchiang
Copy link
Collaborator

Updates #47

@ericchiang ericchiang force-pushed the transaction branch 2 times, most recently from 4c94419 to bfc70b6 Compare October 20, 2022 14:55
@DavidBuchanan314
Copy link

DavidBuchanan314 commented Jul 12, 2025

Is there anything in particular blocking this from getting merged? I think this does exactly what I need 🙏

Edit: I see your comment here about testing on newer yubikeys - I have a 5C that I can use for testing, if that's of any help #160 (comment)

@tianon
Copy link

tianon commented Jul 22, 2025

I needed this, so I took the liberty of rebasing and updating it (which was a little non-trivial, especially in piv_test.go), and I think I've got the same spirit as all the changes here (many of which I had to reimplement green). 🙇

You can find my rebased version at https://github.com/tianon/piv-go/tree/shared (v2...tianon:piv-go:shared, or go-piv:ca0958e...tianon:aee16e4 for the permalink).

I've done some testing with it and it resolved a lot of issues I was having (I'm implementing something that can do ECDSA signatures via a YubiKey against this library, and before applying this, any concurrent attempts to sign would fail, and with this change I can happily make seemingly as many concurrent requests as I want and they just stack up, which is exactly how I want it 💖).

FWIW, I've been testing on a YubiKey 5C, although I will admit I have not run those updated tests (only verified that they compile correctly).

@tianon
Copy link

tianon commented Jul 22, 2025

(Also, to be clear to Eric, if it would be helpful for me to submit that explicitly as a separate PR, I'm happy to, but I didn't want to trample you here unless you want that! ❤️)

Edit (2025-08-22): now opened at #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants