NNTP Proxy/Server Core: Initial Implementation (`Server.go`) #62

go-while · 2025-06-10T22:42:37Z

NNTP Proxy/Server Core: Initial Implementation (`Server.go`)

Overview

This pull request introduces the first version of the NNTP proxy/server core in Server.go. The implementation delivers a robust and extensible NNTP server, complete with user authentication, session management, and support for essential NNTP commands.

✨ Features

🔐 User Authentication

Authenticates users against a .passwd file.
Passwords are securely stored using bcrypt hashes.
Supports account expiration and per-user connection limits.

🧑‍💻 Session Management

Each client connection is tracked as a session.
Automatic cleanup of sessions on disconnect.
Tracks per-session statistics (bytes sent/received).

📡 NNTP Protocol Support

Utilizes Go's net/textproto for parsing and responding to NNTP commands.
Implements core NNTP commands:
- AUTHINFO
- CAPABILITIES
- STAT
- ARTICLE
- BODY
- HEAD
- QUIT
Includes message ID validation.

🔄 Proxy/Server Operation

Supports both plain TCP and TLS/SSL connections.
Configurable listening ports.
Handles multiple concurrent client connections efficiently.
Infinite amount of Providers as backend

👥 User Management

Add new users via a helper function (writes to .passwd.new.* files).
Random username/password generation for automation and scripting.

📝 Logging & Extensibility

Comprehensive logging for authentication, errors, and session events.
Modular code organization for future extension (more NNTP commands, advanced user management, etc).

📝 Notes

Here’s an explanation of the new proxy-related flags for the PR, in Markdown:

Proxy-Related Flags

-proxytcp
- Type: int
- Description: If set, starts the NNTP proxy on the specified TCP port (e.g., -proxytcp=1119). Default is 0 (proxy disabled).
-proxytls
- Type: int
- Description: If set, starts the NNTP proxy on the specified TLS port (e.g., -proxytls=1563). Default is 0 (TLS proxy disabled).
-tlscrt
- Type: string
- Description: Path to the TLS certificate file for the proxy. Default is fullchain.pem in the current directory.
-tlskey
- Type: string
- Description: Path to the TLS private key file for the proxy. Default is privkey.pem in the current directory.
-proxyadduser
- Type: string
- Description: Adds a user to the proxy. Format: 'username|password|maxconns|expires|(no)post'.
  - Password must be cleartext; hashing is done automatically.
  - Expiration can be specified as a Unix timestamp or as a duration (e.g., 7d for 7 days, 12h for 12 hours, 30m for 30 minutes).
  - Example: -proxyadduser="HelloWorld|NotAsecurePassword|5|42d|nopost" creates a user with 5 connections and 42 days until expiration.
-proxypasswdfile
- Type: string
- Description: Path to the password file for the proxy. Default is .proxypasswd in the current directory.

This is the initial implementation; further NNTP commands and features can be added as needed.
This PR establishes the foundation for a Go-based NNTP proxy/server.

Feel free to review, test, and suggest enhancements for future NNTP protocol support!

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 31 out of 33 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

Workers.go:1

[nitpick] The label name "loop" is too generic and could be confused with similar labels elsewhere in the codebase. Consider renaming to "transformLoop" or "yencDecodeLoop" to clarify its purpose.

package main

Server.go:1

Variable name contains typo: 'bcrpyt' should be 'bcrypt'.

package main

Copilot · 2025-10-21T14:51:10Z

rapidyenc/clone_rapidyenc.sh

@@ -1 +1 @@
-git clone https://github.com/animetosho/rapidyenc.git || exit 1
+# test ! -d rapidyenc && git clone https://github.com/animetosho/rapidyenc.git


The entire clone script is commented out but the file still exists. If this functionality has moved to clone_rapidyenc-org.sh, this file should be removed to avoid confusion.

Suggested change

# test ! -d rapidyenc && git clone https://github.com/animetosho/rapidyenc.git

Copilot · 2025-10-21T14:51:11Z

Workers.go

+					for i := 0; i < provider.MaxConns; i++ {
+						waitWorker.Done() // 3 times per worker
+						waitWorker.Done()
+						waitWorker.Done()
+						waitPool.Done() // 1 time per worker
+					}


The comment claims waitWorker.Done() is called "3 times per worker", but it's called 3 times total in the loop iteration, not per connection. This decrements the counter incorrectly if MaxConns > 1. Should likely be for j := 0; j < 3; j++ { waitWorker.Done() } inside the outer loop.

Copilot · 2025-10-21T14:51:11Z

ProxyHelper.go

+	ps.Username = ""        // Clear username to avoid dangling pointer
+	ps.Password = ""        // Clear username to avoid dangling pointer
+	ps.ExpireAt = 0         // Clear expiration time
+	username := ps.Username // Store username for logging
+	ps.Username = ""        // Clear username to avoid dangling pointer
+	ps.Password = ""        // Clear username to avoid dangling pointer
+	ps.ExpireAt = 0         // Clear expiration time
+	log.Printf("Closed session for user '%s'", username)


The username is stored for logging (line 315), but then cleared (line 316) before being used in the log message at line 319. The log will always print an empty string.

Suggested change

ps.Username = "" // Clear username to avoid dangling pointer

ps.Password = "" // Clear username to avoid dangling pointer

ps.ExpireAt = 0 // Clear expiration time

username := ps.Username // Store username for logging

ps.Username = "" // Clear username to avoid dangling pointer

ps.Password = "" // Clear username to avoid dangling pointer

ps.ExpireAt = 0 // Clear expiration time

log.Printf("Closed session for user '%s'", username)

log.Printf("Closed session for user '%s'", ps.Username)

ps.Username = "" // Clear username to avoid dangling pointer

ps.Password = "" // Clear username to avoid dangling pointer

ps.ExpireAt = 0 // Clear expiration time

Copilot · 2025-10-21T14:51:12Z

Config.go

+	//cmdSTAT    = "STAT"
+	//cmdIHAVE   = "IHAVE"
+	//cmdPOST    = "POST"


These command constants are commented out but still referenced throughout the codebase (e.g., in NetConn.go). If they're no longer needed as constants, remove them entirely. If they are still used, uncomment them.

Suggested change

//cmdSTAT = "STAT"

//cmdIHAVE = "IHAVE"

//cmdPOST = "POST"

cmdSTAT = "STAT"

cmdIHAVE = "IHAVE"

cmdPOST = "POST"

go-while added 20 commits June 10, 2025 23:40

Update .gitignore

cef0d65

add basic Proxy module

c81f3fc

typo

60a886d

Update Server.go

562e485

Update Server.go

23926c5

Update Server.go

b7fe690

Update NetConn.go

f4b7bb0

Update NetConn.go

862e081

Update Server.go

6cb50f4

Update Server.go

071e916

Update Server.go

49158da

Update Server.go

85abe14

Update Server.go

4ce9b42

Update main.go

962c3e6

Update Server.go

cb7ce6a

Update Server.go

92c9510

Update Server.go

1bf9787

Update Flags.go

2993d43

Update Flags.go

f844427

Update Flags.go

1d5b882

Copilot AI review requested due to automatic review settings June 10, 2025 22:42

This comment was marked as outdated.

Sign in to view

go-while and others added 6 commits June 11, 2025 00:03

moving funcs to files

5b97e70

Update Utils.go

bc95d1f

Co-authored-by: Copilot <[email protected]>

Update Session.go

e8223a9

Update main.go

8344089

Update Utils.go

da975c6

Merge branch 'testing' of ssh://github.com/go-while/NZBreX into testing

296f3b3

go-while requested a review from Copilot June 10, 2025 23:11

This comment was marked as outdated.

Sign in to view

go-while added 28 commits October 15, 2025 13:16

test mac arm

9533397

retry mac build

98b1c6f

test build

a53498a

test build

0721cfb

test build

d56c03e

test build

70f510f

test build

793ace7

test mac

e9930cc

will darwin arm64 compile with amd64?

d9d9868

try fix filenames

6090a5d

explain error

4b3ca15

fail quick on errors

fda4b9a

fix connection problems

5844e8c

test windows compilation

44c2ef7

flag errors

8cb4933

conn & memlim

ed093db

Update Config.go

fa95a52

debugs & mutex

cf32eeb

counter

793f153

conn timeouts

ba3538c

Update Workers.go

8d7ad8b

testing

5c0f295

adds .zip support

4596aa1

debugs

17b1436

debugs

151e72a

debugs

8ed4464

debugs

0ac2658

debugs

504e002

go-while requested a review from Copilot October 21, 2025 14:49

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NNTP Proxy/Server Core: Initial Implementation (`Server.go`) #62

NNTP Proxy/Server Core: Initial Implementation (`Server.go`) #62

Uh oh!

go-while commented Jun 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 21, 2025

Uh oh!

Copilot AI Oct 21, 2025

Uh oh!

Copilot AI Oct 21, 2025

Uh oh!

Copilot AI Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1 +1 @@
		git clone https://github.com/animetosho/rapidyenc.git \|\| exit 1
		# test ! -d rapidyenc && git clone https://github.com/animetosho/rapidyenc.git

NNTP Proxy/Server Core: Initial Implementation (Server.go) #62

Are you sure you want to change the base?

NNTP Proxy/Server Core: Initial Implementation (Server.go) #62

Uh oh!

Conversation

go-while commented Jun 10, 2025

NNTP Proxy/Server Core: Initial Implementation (Server.go)

Overview

✨ Features

🔐 User Authentication

🧑‍💻 Session Management

📡 NNTP Protocol Support

🔄 Proxy/Server Operation

👥 User Management

📝 Logging & Extensibility

📝 Notes

Proxy-Related Flags

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NNTP Proxy/Server Core: Initial Implementation (`Server.go`) #62

NNTP Proxy/Server Core: Initial Implementation (`Server.go`) #62

NNTP Proxy/Server Core: Initial Implementation (`Server.go`)