web/common: utils: fix infinite value handling in getRelativeTime function #13564
Conversation
dominic-r
changed the title
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rissson
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13564 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 794 794
Lines 40479 40479
=======================================
+ Hits 37518 37519 +1
+ Misses 2961 2960 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dominic-r
force-pushed
the
sdko/closes-13562
branch
from
46a6060 to
f9c3962
Compare
| return rtf.format(Math.round(elapsed / value), key); | ||
| if (Math.abs(elapsed) > value || key === "second") { | ||
| let rounded = Math.round(elapsed / value); | ||
| if (!isFinite(rounded)) { |
There was a problem hiding this comment.
"Because coercion inside the isNaN() function can be surprising, you may prefer to use Number.isNaN()."
There was a problem hiding this comment.
My code doesn't seem to use isNaN at the moment. Sorry if I'd not get what you mean, but do you want me to add a check for NaN or replace part of my patch with a NaN check?
There was a problem hiding this comment.
isFinite() uses isNan() under the covers, as the link documents. Although the isFinite() page has the same quote:
"Because coercion inside the isFinite() function can be surprising, you may prefer to use Number.isFinite()."
Closes #13562
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)