Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: Clarify frontend development. Document local overrides. #13586

Merged
merged 14 commits into from
Mar 27, 2025

Conversation

GirlBossRush
Copy link
Contributor

Details

This PR clarifies the frontend only setup, and adds additional documentation to the authentik config file.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@GirlBossRush GirlBossRush added the documentation Improvements or additions to documentation label Mar 20, 2025
@GirlBossRush GirlBossRush self-assigned this Mar 20, 2025
@GirlBossRush GirlBossRush requested review from a team as code owners March 20, 2025 01:12
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 53809e3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67e4775c8a95a8000852b8cc

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 53809e3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67e4775dab7da500091277a5

Signed-off-by: Teffen Ellis <[email protected]>
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (a247bd5) to head (53809e3).
Report is 62 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13586      +/-   ##
==========================================
+ Coverage   92.75%   92.76%   +0.01%     
==========================================
  Files         794      794              
  Lines       40493    40545      +52     
==========================================
+ Hits        37559    37613      +54     
+ Misses       2934     2932       -2     
Flag Coverage Δ
e2e 47.98% <ø> (+0.02%) ⬆️
integration 24.28% <ø> (-0.01%) ⬇️
unit 90.54% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Teffen! THis looks like a great PR and the dev docs were due for a little cleanup. I took the time to comment on some small things I noticed:

- [Go](https://go.dev/) (1.23 or later)
- [Node.js](https://nodejs.org/en) (22 or later)
- [PostgreSQL](https://www.postgresql.org/) (16 or later)
- [Redis](https://redis.io/) (Latest stable release)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, Redis 7 is preferred. IIRC, it was recently pinned to that version in CI. Not that it really matters anyways as we are moving stuff off Redis anyways in prevision of it's removal

make web-watch
```
6. From the cloned repository root (in a new terminal), start Docker Compose to run the backend services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, how would this exactly work? Running the docker compose command runs the entire stack including the frontend. We override ESBuild's dist, but we still start all containers

tanberry and others added 5 commits March 25, 2025 17:49
Co-authored-by: Dominic R <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Co-authored-by: Dominic R <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Co-authored-by: Dominic R <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Co-authored-by: Dominic R <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Co-authored-by: Dominic R <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Tana M Berry <[email protected]>
Signed-off-by: Teffen Ellis <[email protected]>
Copy link
Contributor

@melizeche melizeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

GirlBossRush and others added 2 commits March 26, 2025 16:59
Signed-off-by: Teffen Ellis <[email protected]>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-53809e3a305558d9f08a9030182c682a9711c6b4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-53809e3a305558d9f08a9030182c682a9711c6b4

Afterwards, run the upgrade commands from the latest release notes.

@melizeche melizeche requested a review from dominic-r March 26, 2025 22:16

def generate_local_config():
"""Generate a local development configuration"""
# TODO: This should be generated and validated against a schema, such as Pydantic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave this as a TODO for now? Otherwise, LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as is, an improvement for future iterations

@tanberry tanberry merged commit 8c7d4d2 into main Mar 27, 2025
94 checks passed
@tanberry tanberry deleted the dev-setup-tidy-v2 branch March 27, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants