-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rac: prevent SSH connections from connecting to wrong endpoint #13589
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
a0a8a0e
to
01d4722
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13589 +/- ##
==========================================
- Coverage 92.68% 85.54% -7.14%
==========================================
Files 794 795 +1
Lines 40479 40702 +223
==========================================
- Hits 37518 34819 -2699
- Misses 2961 5883 +2922
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So this will fix that issue? |
yes |
How do I download this update and deploy it on my server? |
I wouldn't suggest doing this for now as this is still in the development phase and may contain bugs. |
It should be included in hopefully 2025.4 |
And how long till that? |
a951835
to
2ae7250
Compare
Is there a way to use this before the actual release? |
Probably mid to end april |
Is there a way to use this before the actual release? |
You can follow a rebase process similar to #13463 (comment) and build a custom docker container to then deploy on your k8s cluster for example. Do note that since this is still a draft and has not been reviewed by the other members of the team, you may encounter issues. If you do, please LMK and I'll do my best to resolve them |
Is there any way that we could talk on discord and you could help me do this? |
Sure, my user is |
28418ba
to
67829d9
Compare
When using multiple SSH RAC endpoints, connections would sometimes connect to previously used endpoints instead of the newly selected one. This may be caused by connection tokens not being properly invalidated when switching between endpoints.
So, this PR should:
*Always delete connection tokens on disconnect regardless of provider settings
Closes #13609
Closes #13583
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)