Blank regular info messages to keep progress messages running beyond them #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the de-duping is probably better handled within gobble itself, so that other dependants (e.g. grunt-gobble) get the same benefit. Just tried it locally and it seems to work - will raise a PR shortly. +1 to the blanking though - I reckon we should keep this PR minus the lastInfoMessage stuff |
evs-chris
changed the title
|
👍 That's even better. |
evs-chris
added a commit
that referenced
this pull request
Jan 6, 2015
Blank regular info messages to keep progress messages from running beyond them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a gobblefile that uses a few single source nodes for several separate transform paths before merging some and doing bizarro things with others. Each time a node finishes processing, it spams the output with the same completion message a few times. This squashes repeat info messages to avoid that.
It also adds blanking to regular info messages so that previous progress messages don't get partially dangled beyond the end of them.