Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node doesn't keep stderr size updated #8

Merged
merged 2 commits into from
Mar 3, 2015
Merged

Conversation

evs-chris
Copy link
Contributor

...but it does keep stdout updated, so this switches to using process.stdout.columns. I suppose the only risk would be that someone redirects stdout but not stderr?

@Rich-Harris
Copy link
Contributor

Huh, weird, what does that mean in practice? Seems like using the more accurate measure is appropriate thing to do either way, will merge - thanks

Rich-Harris added a commit that referenced this pull request Mar 3, 2015
Node doesn't keep stderr size updated
@Rich-Harris Rich-Harris merged commit bef13c1 into gobblejs:master Mar 3, 2015
@evs-chris
Copy link
Contributor Author

Very weird... there was some face-palmage when I realized why resizing my gobble tmux pane was doing slightly strange things to the output. In practice, if you run gobble 1>/dev/null, you get an exception because you can't read a width off a non-tty descriptor. I can't fathom why you'd ever try to run like that, but I can prevent it. I'll send another PR in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants