fix build hang #56
Merged
fix build hang #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,8 @@ export default function ( node, options ) { | |||
| .then( | |||
| inputdir => copydir( inputdir ).to( dest ), | |||
| err => { throw err; } | |||
| ); | |||
| ) | |||
| .then(() => node.stop()); | |||
There was a problem hiding this comment.
d'oh... I added the start, but didn't think to stop it. 👍
|
This might also be fixed by the solution to #50, but since that's a 'might' and this is a 'does', in it goes! Thanks @lukescott |
|
Released gobble 0.9.1 alongside 0.4.0. Should be good now |
|
Awesome, just updated my project and it works! 24 line build file (10 of it banner setting), so cool! Thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I could tell node.stop() was never called. I fixed that, and added some active() methods for a test I added to use to determine if node was still active or not.
Also had to rework the test/build.js to be similar to test/scenarios.js as there were some race conditions with the tests in that file.
Hopefully this hasn't broken anything else, but all the tests pass.
Related to gobblejs/gobble-cli/pull/11 and gobblejs/gobble-cli/issues/12.