fix(parser): correctly handle empty documents in multi-document yaml#767
Open
semihbkgr wants to merge 1 commit intogoccy:masterfrom
Open
fix(parser): correctly handle empty documents in multi-document yaml#767semihbkgr wants to merge 1 commit intogoccy:masterfrom
semihbkgr wants to merge 1 commit intogoccy:masterfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 77.34% 77.95% +0.60%
==========================================
Files 22 22
Lines 7905 8100 +195
==========================================
+ Hits 6114 6314 +200
+ Misses 1372 1370 -2
+ Partials 419 416 -3 🚀 New features to boost your workflow:
|
f218624 to
1a8acaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes a bug where parsing a multi-document yaml file with an empty document (
---with no content) would cause the parser to stop processing subsequent documents. The document token grouping logic in parser is updated to ensure every document boundary (---), even if empty, results in a document token. Parsing continues after empty documents.fixes #765
As I am not fully familiar with the codebase, I am not certain this is the best or most complete fix and welcome feedback or suggestions for additional test coverage.
Before submitting your PR, please confirm the following.