Skip to content

fix(parser): correctly handle empty documents in multi-document yaml#767

Open
semihbkgr wants to merge 1 commit intogoccy:masterfrom
semihbkgr:fix-parser-on-empty-multi-docs
Open

fix(parser): correctly handle empty documents in multi-document yaml#767
semihbkgr wants to merge 1 commit intogoccy:masterfrom
semihbkgr:fix-parser-on-empty-multi-docs

Conversation

@semihbkgr
Copy link
Copy Markdown
Contributor

It fixes a bug where parsing a multi-document yaml file with an empty document (--- with no content) would cause the parser to stop processing subsequent documents. The document token grouping logic in parser is updated to ensure every document boundary (---), even if empty, results in a document token. Parsing continues after empty documents.

fixes #765

As I am not fully familiar with the codebase, I am not certain this is the best or most complete fix and welcome feedback or suggestions for additional test coverage.

Before submitting your PR, please confirm the following.

  • Describe the purpose for which you created this PR.
  • Create test code that corresponds to the modification

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (81dbf26) to head (1a8acaa).
Report is 41 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   77.34%   77.95%   +0.60%     
==========================================
  Files          22       22              
  Lines        7905     8100     +195     
==========================================
+ Hits         6114     6314     +200     
+ Misses       1372     1370       -2     
+ Partials      419      416       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@semihbkgr semihbkgr force-pushed the fix-parser-on-empty-multi-docs branch from f218624 to 1a8acaa Compare June 23, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser stops after empty document in multi-doc input

2 participants