Skip to content

Conversation

@misino
Copy link
Contributor

@misino misino commented Feb 10, 2019

Single configuration option for solr endpoint will make integration with other projects easier.

@godong9
Copy link
Owner

godong9 commented Feb 15, 2019

I'm not sure about this is really need.

@misino misino force-pushed the add-configuration-option-for-full-solr-host-url branch from 0a61d1e to 71b6f65 Compare February 17, 2019 23:04
@misino
Copy link
Contributor Author

misino commented Feb 23, 2019

There are 2 parts which are solved in this PR.

  1. Current solution expects that URL to solr core is in certain shape <protocol>://<host>[<:port>]/[<rootPath>]/<core>. But what if somebody want to use solr core which is hidden behind proxy (for example on url http://example.com) ?
    Presented solution removes this constraint and gives more flexibility in shape of the endpoint.

  2. Solution in this PR improves a performance a little bit. It is not significant, but at least something. The URL is created only once - in the constructor. Previously it was created on each request.

  • What I see as an improvement is that instead of previous 4 configuration parameters there can be only 1. This can simplify integration into other systems. For example when somebody is storing configuration in database, he does not need to create 4 columns for these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants