Expose the crate's manifest dir to dependent crates #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
When gdextension-api is used as a build dependency during cross-compilation, dependent crates can't reliably locate platform-specific binding files. The
#[cfg]
attributes inload_gdextension_header_rs()
get evaluated for the HOST platform, not the TARGET, causing builds to fail with the wrong bindings.The solution
This PR adds a simple build script that exports the crate's manifest directory via
cargo:root=...
. This lets dependent crates access platform-specific files directly using the standardDEP_GDEXTENSION_API_ROOT
environment variable.What changed?
build.rs
that exportsCARGO_MANIFEST_DIR
ascargo:root
Testing
cargo:root
properly exported and available to dependents asDEP_GDEXTENSION_API_ROOT
Related
This enables godot-rust/gdext#1361 to fix cross-compilation in a clean way without file system searching.