-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCons variant_dir support #1669
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting "my own" PR because so far I've only rebased. Would like to see if anybody has comments on my comments, otherwise I'll probably just adjust things as I see fet.
537328b
to
55e93ea
Compare
Alright, code wise, I think this is ready now. |
3078526
to
f60cac5
Compare
f60cac5
to
1345c46
Compare
Alright, I tested this, it seems to work. To use it, one has to call |
I tested this in the same way and it worked for me! However, shouldn't this be an option given on the command-line, rather than something that developers hard-code into their project? Why not add this to other default options? Also, this only seemed to affect the build artifacts from godot-cpp itself, and not the test project. What do developers need to do so that their artifacts also build in a separate directory? |
This would be possible! I tested this as well, and arrived at this solution:
As you observed, applying |
Supersedes #1439 - it's basically just a rebase. It compiles, but I haven't checked if it does what it says it does (allow godot-cpp to be included from elsewhere).