Fix cases where floats are promoted to doubles and then converted back to floats. (-Wdouble-promotion)#1693
Open
BenLubar wants to merge 3 commits intogodotengine:masterfrom
Open
Fix cases where floats are promoted to doubles and then converted back to floats. (-Wdouble-promotion)#1693BenLubar wants to merge 3 commits intogodotengine:masterfrom
BenLubar wants to merge 3 commits intogodotengine:masterfrom
Conversation
…k to floats. (-Wdouble-promotion)
BenLubar
force-pushed
the
double-promotion
branch
from
cd1a8b3 to
2271e34
Compare
Collaborator
|
Thanks! However, a lot of this is code we periodically copy into godot-cpp from Godot, and if we make these changes, they'll simply be overwritten the next time we synchronize with Godot. PR #1715 is the next synchronization So, these changes would need to have the parts from Godot split off and made into a PR for Godot, and if there's any parts that don't come from Godot (there might not be any), those can remain in a PR for godot-cpp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.