CMake: Revert to single cmake target

[enetheru]

re-mastered:

I've had this thought stuck in my head for a day or so, and a lingering doubt that I might be able to put to rest.

When I embarked on bringing godot-cpp cmake upto a more modern approach it was hard to grasp how it might fit into a standard cmake script. The way I initially thought about it was as three separate libraries, template_debug, template_release and editor.

This is why I made the solution create the three targets, so that users could configure and link to any of the targets they choose.

The latest thought is that this was a mistake on my part, there is only one library, and target is simply a configuration variable.
The output name is just an artifact of convenience and doesnt denote a separate library, but rather a separate configuration of the same library. I conflated terminology differences between the scons configuration and cmake and managed to turn godot target into cmake build target.

My mistaken choice has led to some confusion about the default target, and caused a departure from the synchonicity with SCons.

This PR is painful for me to make and I feel like it might be annoying or disruptive, I'm sorry for that.

Changes:

• Removes the loop that creates multiple targets of godot-cpp.template_debug godot-cpp.template_release godot-cpp.editor. Now a single target is made, godot-cpp with the alias godot::cpp that defaults to template_debug
• GODOTCPP_TARGET is a single value that can be one of the values: template_debug, template_release, editor.

In all other respects the cmake code is the same, and the work I have put into the whole thing remains intact and useful.

Configure and build commands would look like:

# default is template_debug with debug symbols
cmake -S <source_dir> -B <build_dir>
cmake --build <build_dir>

# Ninja, template_release in Release mode
cmake -S <source_dir> -B <build_dir> -DGODOTCPP_TARGET=template_release -DCMAKE_BUILD_TYPE=Release
cmake --build <build_dir>

msvc Ninja-Multi
cmake -S <source_dir> -B <build_dir> -DGODOTCPP_TARGET=template_release
cmake --build <build_dir> --config Release

[enetheru]

There's a long discussion here that led me to this PR, in which both ghuser404 and torets approved this direction
#1730 (comment)

[Naros]

As we discussed on Orchestrator's discord, I agree with moving back to a singular cmake target.

In my experience, most IDE integrations for cmake are designed to be tightly coupled with a single profile that maps to a single CMAKE_BUILD_TYPE such as Debug, Release, RelWithDebInfo, etc. It's a bit unusual to have a single generator configuration that would build a debug, release, and editor build.

[enetheru]

Things were getting messy so i remastered this, its no longer based on anything else.

[dsnopek]

Your explanation makes sense! I had a couple notes below, but I'm fine with going this direction in general.

It sounds like this also addresses the "default target" thing that a couple of folks have brought up, but in a slightly different way.

I attempted to test this locally, and it does seem to build fine!

(However, I'm having some unrelated issue locally where the unit tests are always crashing with stack smashing detected when using a build from CMake, but not from SCons. I'm not sure of the cause, but it doesn't appear to be connected with these changes - I get the problem even when reverting to older versions of godot-cpp that I'm pretty sure I tested in the past, so I'm suspecting something local to my system?)

[enetheru]

I'm suspecting something local to my system?)

Is your system something I can replicate? or remote into? I don't like having issues that go unexplained if I can help in some way.

[dsnopek]

I'm suspecting something local to my system?)

Is your system something I can replicate? or remote into? I don't like having issues that go unexplained if I can help in some way.

I made issue #1741 - I'm hoping someone else on Linux can test it and see if it's just me or not :-)

[enetheru]

@dsnopek Updated with requested changes.