Override for debug_features in SCons and CMake #1737
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Naros raised that after the recent CMake changes his builds now have the
DEBUG_ENABLED
flag set.This is due to using the godot-cpp build target being
editor
ordebug_template
.The CMake scripts now match the SCons scripts, which was not previously the case.
In SCons there is an attribute
debug_features
which is dependent on the target being eithertemplate_debug
oreditor
this is then used to add
DEBUG_ENABLED
andDEBUG_METHODS_ENABLED
to theCPPDEFINES
.This PR adds a new option to both SCons and CMake,
debug_features
andGODOTCPP_DEBUG_FEATURES
respectively, which when unset uses the existing logic, and allows a user to explcitly enable or disable thedebug_features
.This works exactly the same way as the
use_hot_reload
option.