Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override for debug_features in SCons and CMake #1737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enetheru
Copy link
Collaborator

@Naros raised that after the recent CMake changes his builds now have the DEBUG_ENABLED flag set.

This is due to using the godot-cpp build target being editor or debug_template.
The CMake scripts now match the SCons scripts, which was not previously the case.

In SCons there is an attribute debug_features which is dependent on the target being either template_debug or editor
this is then used to add DEBUG_ENABLED and DEBUG_METHODS_ENABLED to the CPPDEFINES.

This PR adds a new option to both SCons and CMake, debug_features and GODOTCPP_DEBUG_FEATURES respectively, which when unset uses the existing logic, and allows a user to explcitly enable or disable the debug_features.

This works exactly the same way as the use_hot_reload option.

override setting debug features
@enetheru enetheru marked this pull request as ready for review March 10, 2025 13:55
@enetheru enetheru requested a review from a team as a code owner March 10, 2025 13:55
@enetheru enetheru added the topic:buildsystem Related to the buildsystem or CI setup label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant