OpenXR: Add passthrough demo#1273
Conversation
|
IDK what to make of the CI failure... |
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
2 times, most recently
from
2684eda to
4a37a1c
Compare
|
I've added a toggle feature to switch between passthrough and no passthrough so it has the full demonstration of what is discussed in the manual. |
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
from
4a37a1c to
d9f27d0
Compare
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Style and writing looks good now!
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
from
d9f27d0 to
90236f4
Compare
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
from
90236f4 to
50c8f13
Compare
| elif XRInterface.XR_ENV_BLEND_MODE_ADDITIVE in modes: | ||
| xr_interface.environment_blend_mode = XRInterface.XR_ENV_BLEND_MODE_ADDITIVE | ||
| else: | ||
| push_error("Passthrough not supported!") |
There was a problem hiding this comment.
I feel like having some feedback inside the demo itself would also be nice to have if passthrough isn't supported by the runtime.
There was a problem hiding this comment.
I've added a message that fades out after time that presents this information to the user if applicable.
You can test it on a Meta Quest by simply turning passthrough support of in project settings.
Its maybe a little overkill but its a fun solution :)
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
from
50c8f13 to
270f717
Compare
|
This looks good from my review during the morning meeting. |
|
@BastiaanOlij Before merging, can you rename the |
BastiaanOlij
force-pushed
the
openxr-passthrough-demo
branch
from
270f717 to
e92e498
Compare
|
@Calinou no worries, folder has been renamed :) |
6 participants
This PR adds a new OpenXR demo that shows the setup of passthrough (note that once we are happy with this demo, we should update that help page and direct it to the demo).
For now it's a bare bones demo just to show the basics but we can improve upon it.
The PR also makes sure all our copies of
start_vr.gdare in sync.