Skip to content

Style: Integrate new #pragma once syntax #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Mar 10, 2025

With #pragma once being the new stylistic syntax utilized in the main repo, this aims to update the docs to reflect that

@Repiteo Repiteo added enhancement topic:codestyle content:example code Issues and PRs involving code examples labels Mar 10, 2025

Verified

This commit was signed with the committer’s verified signature.
Repiteo Thaddeus Crews
@Repiteo Repiteo force-pushed the style/pragma-once branch from 630da6f to da33f97 Compare March 10, 2025 14:56
@skyace65
Copy link
Contributor

skyace65 commented Apr 1, 2025

I know technically this is about changes in 4.5. But is there any reason not to have it in the 4.4 docs? I don't do coding for the engine so maybe I'm off here, but I wouldn't expect people to automatically assume they need to use the master branch for engine development.

@skyace65 skyace65 mentioned this pull request Apr 14, 2025
@mhilbrunner
Copy link
Member

mhilbrunner commented Apr 14, 2025

But is there any reason not to have it in the 4.4 docs?

There could be an argument to keep guidelines for a version to the state that applied to that version, i.e., to have Godot 3 docs reflect Godot 3 guidelines. I think that argument is stronger for major versions however, I don't think the complexity is worth it for minor versions.

And kinda moot anyway considering we mostly decided to eventually move to one (current) set of contributor documentation and to move it out of the (user-facing) docs. I see no harm in cherrypicking these (doesn't seem too critical either though).

@skyace65 skyace65 merged commit 28958a7 into godotengine:master Apr 15, 2025
2 checks passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants