Skip to content

Conversation

anasmustafa123
Copy link

Problem: the character when moving down with angle the sprite was looking up not down
so i seperated the code responsible of the flipping

Problem: the character when moving down with angle 
the sprite was looking up not down
so i seperated the code responsible of the flipping
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C# code needs to be changed to match as well

anasmustafa123 and others added 2 commits October 6, 2025 13:09
Removed unnecessary comments in GDScript code.
@AThousandShips AThousandShips added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation labels Oct 6, 2025
@AThousandShips
Copy link
Member

This also needs to be changed in the demo project as they should match

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, with some minor details

But would need a matching PR on the demo projects to keep these synced

if (velocity.X != 0)
{
animatedSprite2D.Animation = "walk";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines 302 to 303
animatedSprite2D.FlipV = false;
// See the note below about the following boolean assignment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
animatedSprite2D.FlipV = false;
// See the note below about the following boolean assignment.
// See the note below about the following boolean assignment.
animatedSprite2D.FlipV = false;

Or flip the order above in GDScript

.. tabs::
.. code-tab:: gdscript GDScript

if velocity.x != 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if velocity.x != 0:
if velocity.x != 0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants