Skip to content

Fix RTD language switcher redirecting to nonexistent /en/4.x/ branch #11349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Fix RTD language switcher redirecting to nonexistent /en/4.x/ branch #11349

merged 1 commit into from
Oct 10, 2025
+9 −0

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 6, 2025 •
edited
Loading

If we were redirected to /en/4.x/ as a result of the RTD language selector, redirect to /en/stable/ instead, as English does not have a 4.x branch.

For maintenance reasons, non-English languages have a single 4.x branch that is the counterpart of 4.3, 4.4, 4.5 and so on.).

image

Bugsquad edit: Followup to #11304

@Calinou Calinou added bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end labels Oct 6, 2025
@Calinou Calinou force-pushed the javascript-redirect-english-4.x branch from 54df64b to c95c900 Compare October 6, 2025 20:48
rburing
rburing approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and the implementation looks fine.

It would be nice to match and replace only the start of the path, but realistically it doesn't seem like the current approach will cause any issue.

@Calinou Calinou mentioned this pull request Oct 6, 2025
Merged
Mickeon
Mickeon approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bothered me for the longest time.

AThousandShips
AThousandShips reviewed Oct 7, 2025
View reviewed changes
@mhilbrunner
Copy link
Member

@Calinou Needs a rebase now after #11342

@Calinou Calinou mentioned this pull request Oct 9, 2025
Closed
@Calinou Calinou force-pushed the javascript-redirect-english-4.x branch from c95c900 to fa12131 Compare October 9, 2025 20:55
@Calinou
Fix RTD language switcher redirecting to nonexistent /en/4.x/ branch
1ffd71c 
If we were redirected to `/en/4.x/` as a result of the RTD language selector,
redirect to `/en/stable/` instead, as English does not have a `4.x` branch.

For maintenance reasons, non-English languages have a single `4.x` branch
that is the counterpart of `4.3`, `4.4`, `4.5` and so on.).
@Calinou Calinou force-pushed the javascript-redirect-english-4.x branch from fa12131 to 1ffd71c Compare October 9, 2025 20:55
@mhilbrunner mhilbrunner merged commit c7cfd7f into godotengine:master Oct 10, 2025
1 check passed
@mhilbrunner
Copy link
Member

Thanks!

@Calinou Calinou deleted the javascript-redirect-english-4.x branch October 11, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@rburing rburing rburing approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees

No one assigned

Labels

bug cherrypick:4.0 cherrypick:4.1 cherrypick:4.2 cherrypick:4.3 cherrypick:4.5 content:website Issues related to adding website features and fixing bugs, whether on the front or back-end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switching languages shows "page not found"

5 participants

@Calinou @mhilbrunner @rburing @Mickeon @AThousandShips