Conversation
Calinou
added
area:manual
Calinou
force-pushed
the
lights-and-shadows-contact
branch
from
September 16, 2026 17:42
3bbe8a0 to
0aeebc8
Compare
AThousandShips
approved these changes
Sep 17, 2026
AThousandShips
left a comment
AThousandShips
left a comment
Member
There was a problem hiding this comment.
LGTM can't speak to the correctness
| Contact shadows are only available in the Forward+ renderer. | ||
|
|
||
| By default, contact shadows are *allowed* in each DirectionalLight3D, but they | ||
| are not rendered until **Rendering > Lights and Shadows > Contact Shadow > Enabled** |
Member
There was a problem hiding this comment.
Suggested change
| are not rendered until **Rendering > Lights and Shadows > Contact Shadow > Enabled** | |
| are not rendered unless **Rendering > Lights and Shadows > Contact Shadow > Enabled** |
I'd say is more meaningful
mhilbrunner
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project used for screenshots: test_contact_shadows_2.zip