Fixes for VSCode attached debugging and related improvements. #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'launch' and 'attach' modes are working with these changes. The root problems were related to the version of the attached project not being detected properly and file paths not being correctly calculated when attached. The networking code that had version-dependent behavior is now a bit more robust and won't break if minor versions were to ever exceed 1 digit. When using 'attach' mode, the version info wasn't available at all, causing most (all?) network messages to be ignored.
|
Hey @ecosky, thanks for contributing this, and I'm really excited to see attach sessions finally working, but unfortunately I'm going to have to ask you to resubmit this PR with your changes in a branch named something other than Having your changes in the |
|
Hi there, that makes sense. I'll put it in a different branch and submit a different PR. |
|
Thanks for understanding! |
|
Sure thing! Here you go: #784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'launch' and 'attach' modes are working with these changes. The root problems were related to the version of the attached project not being detected properly and file paths not being correctly calculated when attached. The networking code that had version-dependent behavior is now a bit more robust and won't break if minor versions were to ever exceed 1 digit. When using 'attach' mode, the version info wasn't available at all, causing most (all?) network messages to be ignored.
Tested with attach and launch modes, and with a built vsix.