-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DebugAdapter variables overhaul #793
base: master
Are you sure you want to change the base?
Conversation
Fixes the VSCode watch window freeze due to missing response in case of exception. See related godotengine#779
Thanks for linking that issue, I haven't been following engine development that closely so I didn't know this was happening. Will the DAP implementation support the remote scene inspector? |
Should fix:
Doesn't fix:
|
I'm not sure - just found by looking at the code. @rsubtil should know better. @DaelonSuzuka, could you review/recommend who can review this PR? Thanks again for maintaining and improving this extension, it is very useful! |
Yeah I'm gonna review it tomorrow or this weekend. |
Fixes multiple issues with variables window for godot 4 projects.

Note: there is a great initiative of bringing DAP implementation directly into godot debug engine: https://github.com/godotengine/godot/blob/af56d6e8e88e56110577f3bbcfa2eb5cdcc71356/editor/debugger/debug_adapter/debug_adapter_protocol.cpp by @rsubtil and others. We will still need the backward-compatible implementation for now, which also includes remote scene inspector. In future, once the godot server DAP implementation matures, and where will be no need for backward compatibility, we should switch directly to it.