Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D mesh drawing is broken #97793

Closed
Lielay9 opened this issue Oct 3, 2024 · 2 comments · Fixed by #97792
Closed

2D mesh drawing is broken #97793

Lielay9 opened this issue Oct 3, 2024 · 2 comments · Fixed by #97792

Comments

@Lielay9
Copy link
Contributor

Lielay9 commented Oct 3, 2024

Tested versions

Bisect: [e2c6daf]

System information

Godot v4.4.dev (98deb2a) - Windows 10.0.22631 - Multi-window, 1 monitor - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 31.0.15.3699) - AMD Ryzen 9 7950X 16-Core Processor (32 threads)

Issue description

After #90400 drawing 2D meshes (CanvasItem.draw_mesh(), RenderingServer.canvas_item_add_mesh(), Polygon2D, MeshInstance2D etc.; haven't tested all) is broken. Some errors are spammed varying a little depending on what is being tried to draw:

E 0:00:00:0662   RenderingDevice::render_pipeline_create: Shader vertex input location (0) not provided in vertex input description for pipeline creation.
  <C++ Error>    Condition "!found" is true. Returning: RID()
  <C++ Source>   servers\rendering\rendering_device.cpp:3477 @ RenderingDevice::render_pipeline_create()

E 0:00:00:0662   RendererCanvasRenderRD::CanvasShaderData::_create_pipeline: Condition "pipeline.is_null()" is true.
  <C++ Source>   servers\rendering\renderer_rd\renderer_canvas_render_rd.cpp:1459 @ RendererCanvasRenderRD::CanvasShaderData::_create_pipeline()

E 0:00:00:0662   RenderingDevice::draw_list_bind_render_pipeline: Parameter "pipeline" is null.
  <C++ Source>   servers\rendering\rendering_device.cpp:4087 @ RenderingDevice::draw_list_bind_render_pipeline()

E 0:00:00:0662   RenderingDevice::draw_list_set_push_constant: This render pipeline requires (0) bytes of push constant data, supplied: (16)
  <C++ Error>    Condition "p_data_size != dl->validation.pipeline_push_constant_size" is true.
  <C++ Source>   servers\rendering\rendering_device.cpp:4299 @ RenderingDevice::draw_list_set_push_constant()

Steps to reproduce

Minimal reproduction project (MRP)

pipeline-bug.zip

@DarioSamo
Copy link
Contributor

DarioSamo commented Oct 3, 2024

This is fixed by #97792

@Lielay9
Copy link
Contributor Author

Lielay9 commented Oct 4, 2024

:/ Had I started writing 5 minutes later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants