Properly utilize surface information when creating pipelines and vertex arrays in canvas renderer #97792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex arrays in canvas renderer
DarioSamo
approved these changes
Oct 3, 2024
YeldhamDev
approved these changes
Oct 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #97793
The deleted code was unnecessary as it should be calculated within
_get_pipeline_specialization_or_ubershader(). BUT_get_pipeline_specialization_or_ubershader()needs everything to be passed in, which was missing.Finally, the VertexAttribute variable needs to be reset while inside the loop otherwise variables leak between attributes. This didn't impact the 3D renderers because they disable any unused attributes.
CC @YeldhamDev @stuartcarnie @DarioSamo