Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPRequest: Expose and add methods to make working with headers easier #62962

Closed
wants to merge 0 commits into from
Closed

HTTPRequest: Expose and add methods to make working with headers easier #62962

wants to merge 0 commits into from

Conversation

Kubulambula
Copy link
Contributor

@Kubulambula Kubulambula commented Jul 12, 2022 •
edited
Loading

Exposes has_header() and get_header_value() methods and adds get_dictionary_from_headers method.

@Kubulambula Kubulambula requested a review from a team as a code owner July 12, 2022 18:45
@Calinou Calinou added this to the 4.0 milestone Jul 12, 2022
Faless
Faless requested changes Jul 16, 2022
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing documentation (https://docs.godotengine.org/en/latest/community/contributing/updating_the_class_reference.html#doc-updating-the-class-reference) but it's otherwise good 🏆 .

@Kubulambula Kubulambula requested a review from a team as a code owner July 20, 2022 11:32
@Kubulambula Kubulambula requested a review from Faless July 20, 2022 11:36
@Kubulambula
Copy link
Contributor Author

Should be good now

mhilbrunner
mhilbrunner approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, commits need to be squashed. Good work!

@Kubulambula
Copy link
Contributor Author

Due to my idiocy I accidentally made a merge commit and now I cannot squash.
The last commit how ever has all the relevant commits squashed if that is helpful.

@Kubulambula Kubulambula mentioned this pull request Jul 31, 2022
Closed
@Kubulambula
Copy link
Contributor Author

Should be fine in 63713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Faless Faless Awaiting requested review from Faless

Assignees
No one assigned
Labels
archived enhancement topic:network
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kubulambula @mhilbrunner @Faless @Calinou @akien-mga