Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] SpatialEditorPlugin should only handle Spatial #80197

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #80179

The test for Resource should only affect the edit(nullptr) part.

Sorry for the regression, I didn't test that PR thoroughly :(

@timothyqiu timothyqiu added bug topic:editor regression cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 3, 2023
@timothyqiu timothyqiu added this to the 3.6 milestone Aug 3, 2023
@lawnjelly
Copy link
Member

Seems to work for selecting scripts and for moving points on the OccluderShapePoly. But leave to @akien-mga to review as I'm not super familiar with this code (like where it is used from etc).

@akien-mga akien-mga merged commit b776cf5 into godotengine:3.x Aug 3, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3. (Together with #79947.)

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants